Config for start options cache #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okey/cache.go test: little chances to adapter new behavior gokey/cache_test.go refactor: change that functions hash to generate a callbacks gokey/hash.go test: little change in test TestGenerateMD5HashFromKey gokey/hash_test.go feat: new function to verified if user put the capacity of cache size gokey/helpers.go
refactor: delete variable err in hashFunc gokey/cache.go test: new test are add gokey/hash_test.go
test : new test are add gokey/hash_test.go
tomiok
reviewed
Mar 26, 2023
gokey/cache.go
Outdated
| type Options struct { | ||
| maxSize int | ||
| aHast string | ||
| tll float64 // in Newcache or their methods? |
gokey/cache.go
Outdated
| @@ -27,11 +33,14 @@ var ( | |||
| ErrExpiredKey = errors.New("key has expired") | |||
| ) | |||
|
|
|||
| func newCache() *Cache { | |||
| func newCache(o ...Options) *Cache { | |||
There was a problem hiding this comment.
tenemos que validar que options no venaga nil y/o vacio
There was a problem hiding this comment.
se me habia olvidado que options seria pasado por referencia, sorry.
gokey/cache.go
Outdated
Comment on lines
23
to
25
| maxSize int | ||
| aHast string | ||
| tll float64 // in Newcache or their methods? |
There was a problem hiding this comment.
- todos deben estar exportados, sino por fuera del paquete no van a poder llamarlo.
aHastno entiendo que es, si es hash, no deberia ser un string sino algun tipo nuestro para que sea mas facil para el cliente y no dejarselo libre- Options tiene que tener godocs porque esta exportada
There was a problem hiding this comment.
- Ahash es el atributo de hash a elegir; "md5", "sha1" o "sha256".
Entiendo
tomiok
reviewed
Mar 27, 2023
| var options *Options | ||
|
|
||
| if len(o) < 1 || o[0] == nil { | ||
| options = &Options{} |
There was a problem hiding this comment.
Aca deberias poner una por defecto.
tomiok
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripcion
Agregada la estructura Options que contendra los valores que seran pasados a la función newCache. Entre ellos están la capacidad maximá del cache, el algorithmo hash a utilizar y el TLL (aún no se donde deberia colocarlo).
agregados los test para los nuevos algorithmos, así como se refactorizo las funciones para agregar u/o quitar algunos hash.
Issue Relacionada
#28
Motivacion y Contexto
El cache se inicializaba con valores por defectos lo cual era rigido a la hora de querer una capidad máxima de
almacenamiento o algorithmo de cifrado. Con estos cambios haran que el usuario tenga mas libertad al decidir algunas
caracteriticas.
Aun permiten iniciar el cache con valores por defectos si no se pasan los argumentos al momento de instanciarlo.
Como fue probado
Se agregaron otros test para probar los nuevos hash
Screenshots / capturas de pantalla (si es necesario)
Tipo de cambio
Checklist
master!.master(lado izquierdo). Tambien de que estas usando los ultimos cambios enmaster.go mod tidy && go mod vendorgo fmt -sgo vet