kadai4 yasuno #57
Open
kadai4 yasuno #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2018 03:28
knsh14
reviewed
Dec 3, 2018
| newYearsDay := time.Date(2018, 1, 1, 0, 0, 0, 0, location) | ||
| endDay := time.Date(2018, 1, 4, 0, 0, 0, 0, location) | ||
| if !now.Before(newYearsDay) && !now.After(endDay) { | ||
| fortune = "大吉" |
There was a problem hiding this comment.
else が長く続くならここで return "大吉", nil としたほうがネストが浅くなって良いです
knsh14
reviewed
Dec 3, 2018
| randomInt = rand.Intn(17) | ||
| switch randomInt { | ||
| case 0: | ||
| fortune = "大大吉" |
There was a problem hiding this comment.
この変数に入れてなにか処理をするとかもないので、さっと return "運勢", nil していいと思います。
default の場合は return "", errors.New(...) となります。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
● JSON形式でおみくじ結果を返す
● 正月(1/1-1/3)だけ大吉にする
● ハンドラテストを書いてみる