feat: Add support to emit Metrics same as Traces via OTEL #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zurvarian
commented
Feb 6, 2025
| var tracer *trace.TracerProvider | ||
| if cfg.EnableTrace { | ||
| log.Printf("Enabling CloudTrace exporter with sample rate: %f\n", cfg.ServerConfig.TraceSampleRate) | ||
|
|
||
| grpcOptions = append(grpcOptions, | ||
| grpc.UnaryInterceptor(otelgrpc.UnaryServerInterceptor()), |
There was a problem hiding this comment.
UnaryServerInterceptor and StreamServerInterceptor have been deprecated in favour of NewServerHandler()
Zurvarian
commented
Feb 6, 2025
| EnableTrace: viper.GetBool(EnableTrace), | ||
| TraceSampleRate: viper.GetFloat64(TraceSampleRate), | ||
| TraceServiceName: viper.GetString(TraceServiceName), | ||
| EnableGRPCCollector: viper.GetBool(TraceEnableGRPCCollector), |
There was a problem hiding this comment.
I've added the Trace prefix for both EnableGRPCCollector and EnableHTTPCollector to differentiate them from the counter parts of Metrics.
It is important to mention that the OTLP endpoint for Traces and Metrics could or could not be the same.
Zurvarian
commented
Feb 6, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| options = append(options, metric.WithReader(metric.NewPeriodicReader(exporter))) |
There was a problem hiding this comment.
There are options we can configure at the PeriodicReader, like the frequency, but I didn't want to make configuration too complex, and the defaults are sensible.
|
/gcbrun |
1 similar comment
|
/gcbrun |
Qohar97
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat
What this PR does / Why we need it:
Add support to emit metrics (GRPC, Redis, etc..) via OTLP.
Which issue(s) this PR fixes:
Closes #455
Special notes for your reviewer:
None