Skip expired backfills instead of returning error #1674
+91
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glindstedt
commented
Nov 7, 2023
| }) | ||
|
|
||
| // Depends on pendingReleaseTimeout | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
This is a bit ugly, would be nice if we could have something like k8s.io/utils/clock/testing to pass the time
glindstedt
force-pushed
the
skip-expired-backfills
branch
from
7924516 to
f31067d
Compare
If a single backfill has expired it would cause the whole FetchMatches call to error out. Now the backfill will be skipped instead similar to the NotFound case. The status code returned for attempting to acknowledge or update an expired backfill is changed from Unavailable since the operation is not retryable.
glindstedt
force-pushed
the
skip-expired-backfills
branch
from
f31067d to
7fc3eb3
Compare
glindstedt
commented
Nov 7, 2023
| @@ -183,7 +183,7 @@ func synchronizeRecv(ctx context.Context, syncStream synchronizerStream, m *sync | |||
| err = createOrUpdateBackfill(ctx, backfill, ticketIds, store) | |||
| if err != nil { | |||
| e, ok := status.FromError(err) | |||
| if err == errBackfillGenerationMismatch || (ok && e.Code() == codes.NotFound) { | |||
| if err == errBackfillGenerationMismatch || (ok && (e.Code() == codes.NotFound || e.Code() == codes.FailedPrecondition)) { | |||
glindstedt
requested review from
aLekSer,
HazWard,
calebatwd,
sawagh,
amg84,
scosgrave,
markmandel,
joeholley,
kazshinohara,
kemurayama,
govargo and
ashutosji
as code owners
lonefreak
approved these changes
Nov 13, 2023
govargo
added a commit
to govargo/open-match
that referenced
this pull request
Jun 24, 2024
govargo
added a commit
to govargo/open-match
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
If a single backfill has expired it would cause the whole FetchMatches call to error out. Now instead the backfill will be skipped, similar to the
NotFoundcase.The status code returned for attempting to acknowledge or update an expired backfill is changed from Unavailable since the operation is not retryable. I opted for
FailedPrecondition, but maybeInvalidArgumentcould make more sense since you can't "revive" the backfill, only create a new one if it expired.Special notes for your reviewer:
There are some formatting changes from format-on-save, let me know if I should remove them to make the PR clearer.