Unblocks Agones release PR by waiting for either the Agones dev version or release version

[igooch]

What type of PR is this?

/kind hotfix

What this PR does / Why we need it:

The current release PR #4077 is blocked by the upgrade tests. The Logs Explorer showed the error PollUntilContextTimeout timed out while attempting upgrade to Agones version 1.46.0-dev-633ac4f. which is consistent with the code

agones/test/upgrade/main.go

Lines 316 to 328 in 8166704

	// Wait for the helm release to install. Waits the same amount of time as the Helm timeout.
	var helmStatus string
	err = wait.PollUntilContextTimeout(ctx, 10*time.Second, Timeout, true, func(_ context.Context) (done bool, err error) {
	helmStatus = checkHelmStatus(config.agonesVersion)
	if helmStatus == "deployed" {
	return true, nil
	}
	return false, nil
	})
	if err != nil || helmStatus != "deployed" {
	log.Fatalf("PollUntilContextTimeout timed out while attempting upgrade to Agones version %s. Helm Status %s",
	config.agonesVersion, helmStatus)
	}

that is waiting for the "dev" chart to be installed. However, the release PR changes the chart from agones-1.46.0-dev to agones-1.46.0, so the test waits indefinitely.

This PR updates the waiting code to wait for either agones-{DevVersion}-dev or agones-{DevVersion}.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

[markmandel]

(non blocking) in the future, may want to use a library like https://github.com/blang/semver (which we use in a few util scripts) to work with semantic versions, rather than regex things.

[agones-bot]

Build Failed 😭

Build Id: 2a484667-6651-45b6-ad8a-3dccb9a095fb

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 🥳

Build Id: af26185f-e1d2-4a03-9a27-d121a5a33a00

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-5925c64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-5925c64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-5925c64-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-5925c64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-5925c64
• Linux C++ SDK (build): agonessdk-1.46.0-dev-5925c64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.46.0-dev-5925c64.zip

A preview of the website (the last 30 builds are retained):

• https://5925c64-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4078/head:pr_4078 && git checkout pr_4078
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-5925c64