feat(a11y): improve the a11y of the example #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking a look at this and diving in! With Google I/O coming up quickly, I'm going to hold off on reviewing/merging this until after that. I've got a ton of other things that I need to prep for. I really appreciate the work you've done on this!! thanks! |
|
ok, don't worry (I don't envy your ton of things related with the incoming Google I/O hahaha) but please don't forget this pull request ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #158.
I've checked the example with different mobiles resolutions and should no be any problems using the table instead of the previous HTML.