Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [Not for review] removed GuardeBy #2060

Closed
wants to merge 1 commit into from
Closed

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 3, 2023

As part of #1938. This pull request is an experiment to see the effect of the GuardedBy annotation.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@suztomo
Copy link
Member Author

suztomo commented Oct 3, 2023

The Bazel build caught the bug!

https://github.com/googleapis/sdk-platform-java/actions/runs/6397756942/job/17366399303?pr=2060:

external/com_google_api_gax_java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonClientCallImpl.java:287: error: [GuardedBy] This access should be guarded by 'this.lock', which is not currently held
        if (inDelivery && newActiveDeliveryLoop) {
            ^
    (see https://errorprone.info/bugpattern/GuardedBy)
external/com_google_api_gax_java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonClientCallImpl.java:292: error: [GuardedBy] This access should be guarded by 'this.lock', which is not currently held
        inDelivery = true;
        ^
    (see https://errorprone.info/bugpattern/GuardedBy)

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant