fix: reuse single Manifest instance for releases and pull requests#1189
Open
sehawq wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: reuse single Manifest instance for releases and pull requests#1189sehawq wants to merge 1 commit intogoogleapis:mainfrom
sehawq wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The main() function was creating two separate Manifest instances - one for creating releases and one for creating pull requests. Each call to loadOrBuildManifest() triggers GitHub API requests to fetch repository config and release history. This is especially costly when draft releases are enabled because draft release resolution requires iterating through more GitHub API pages to find tagged releases, effectively doubling the API overhead. Hoist the loadOrBuildManifest() call above both conditional blocks so a single instance is shared across both operations. Fixes googleapis#1169
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
main()function previously instantiated two separateManifestobjects: one for creating releases and another for creating pull requests. Each call toloadOrBuildManifest()triggered GitHub API requests to fetch repository configuration and release history.When
draft: trueis enabled, this redundancy becomes especially costly because draft release resolution requires iterating through more GitHub API pages to find tagged releases, effectively doubling the API overhead.This PR hoists the
loadOrBuildManifest()call above both conditional blocks so a single, shared instance is used for both operations.Fixes #1169