fix: remove unused setting of git remote add gh-token in major and minor tag updating#1172
Open
dlaehnemann wants to merge 2 commits intogoogleapis:mainfrom
Open
fix: remove unused setting of git remote add gh-token in major and minor tag updating#1172dlaehnemann wants to merge 2 commits intogoogleapis:mainfrom
git remote add gh-token in major and minor tag updating#1172dlaehnemann wants to merge 2 commits intogoogleapis:mainfrom
Conversation
… minor tag updating Signed-off-by: David Laehnemann <1379875+dlaehnemann@users.noreply.github.com>
…inor tag updating Signed-off-by: David Laehnemann <1379875+dlaehnemann@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This was referenced Dec 12, 2025
Author
|
In the case where this line came up as flagged by @coderabbitai for us, we have confirmed that the tag updating works properly without this extra (unused) remote being set up. @chingor13 is there anything else I can do to help get this pull request rolling and the question cleared up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been flagged about this by @coderabbitai in one of our repositories, and looking at this in more detail I agree with the analysis:
snakemake/snakemake-github-action#46 (comment)
Namely, the git remote
gh-tokenthat is added here, is not used anywhere. So unless this gets used implicitly, it should not be needed and should be omitted in both the CI and the suggestion in theREADME.md.If this is indeed used implicitly in some way (for example to be able to delete and add tags in the repository), then it should always be adjusted to respective repository, right? In that case, I would suggest to revert the change in
.github/workflows/release-please.yamland instead change the line in theREADME.mdto something like:And maybe also mention that this requires adjusting in the text before it. But in this way, the line will not run anyways and throw an error, alerting anybody copying it, that they need to adjust this.
All of this was originally added in #121 , so maybe @bcoe and/or @bharathkkb can quickly asses this?