fix: changelog-host
parameter ignored when using manifest configuration
#1151
+93
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
changelog-host
action parameter was being ignored when using manifest configuration files (release-please-config.json
). This caused changelog links to always point togithub.com
instead of the specified GitHub Enterprise Server URL, breaking changelog functionality for GitHub Enterprise users.Root Cause
The original implementation attempted to pass
changelogHost
throughmanifestOverrides
to theManifest.fromManifest()
method. However,changelogHost
is not part of theManifestOptions
interface - it belongs to the per-pathReleaserConfig
interface. This architectural mismatch meant the parameter was silently ignored.Solution
Modified the
loadOrBuildManifest()
function to:changelogHost
through manifest optionschangelogHost
for all configured paths when the action input is provided and differs from the default GitHub URLTechnical Details
manifestOverrides.changelogHost
(invalid approach)manifest.repositoryConfig[path].changelogHost
for each path after manifest loadingchangelog-host
input is provided and differs fromhttps://github.com
Testing
Impact
This fix enables GitHub Enterprise Server users to properly use the
changelog-host
parameter with manifest configurations, ensuring changelog links point to their custom Git hosting instead