Skip to content

Updating descriptions create query #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shivanee-p wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Updating descriptions create query #1442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50cce00
docs: Add parameters to remaining overloads (consolidated PR)
shivanee-p Feb 11, 2026
683af75
Addressed docs failures.
shivanee-p Feb 11, 2026
49cdd6e
docs: Add parameters to createQuery overloads
shivanee-p Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,7 @@ class Transaction extends DatastoreRequest {
* transaction.
*
* @param {CallOptions | https://googleapis.github.io/gax-nodejs/global.html#CallOptions} [gaxOptions] Request configuration options.
* @param {function} callback The callback function.
* @param {?error} callback.err An error returned while making this request.
* If the commit fails, we automatically try to rollback the transaction
* (see {module:datastore/transaction#rollback}).
* @param {object} callback.apiResponse The full API response.
* @returns {Promise<CommitResponse>} The full API response.
*
* @example
* ```
Expand All @@ -159,16 +155,26 @@ class Transaction extends DatastoreRequest {
*/
commit(gaxOptions?: CallOptions): Promise<CommitResponse>;
/**
* @param {object} [gaxOptions] Request configuration options, outlined here:
* https://googleapis.github.io/gax-nodejs/global.html#CallOptions.
* @param {object} [gaxOptions] Request configuration options.
* See {@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions CallOptions Docs}.
* @param {function} callback The callback function.
* @param {?error} callback.err An error returned while making this request.
* If the commit fails, we automatically try to rollback the transaction
* (see {module:datastore/transaction#rollback}).
* @param {object} callback.apiResponse The full API response.
*/
commit(callback: CommitCallback): void;
/**
* @param {CallOptions} [gaxOptions] Request configuration options.
* See {@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions CallOptions Docs}.
* @param {CommitCallback} callback The callback function.
*/
commit(gaxOptions: CallOptions, callback: CommitCallback): void;
/**
* @param {CallOptions} [gaxOptionsOrCallback] Request configuration options.
* See {@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions CallOptions Docs}.
* @param cb The callback function.
*/
commit(
gaxOptionsOrCallback?: CallOptions | CommitCallback,
cb?: CommitCallback,
Expand Down Expand Up @@ -203,8 +209,7 @@ class Transaction extends DatastoreRequest {
*
* @see {@link Query}
*
* @param {string} [namespace] Namespace.
* @param {string} kind The kind to query.
* @param {string} [kind] The kind to query.
* @returns {Query}
*
* @example
Expand Down Expand Up @@ -261,9 +266,28 @@ class Transaction extends DatastoreRequest {
* ```
*/
createQuery(kind?: string): Query;
/**
* @param {string[]} [kind] The kind to query.
* @returns {Query}
*/
createQuery(kind?: string[]): Query;
/**
* @param {string} namespace Namespace to query.
* @param {string} kind Kind to query.
* @returns {Query}
*/
createQuery(namespace: string, kind: string): Query;
/**
* @param {string} namespace Namespace to query.
* @param {string[]} kind Kind(s) to query.
* @returns {Query}
*/
createQuery(namespace: string, kind: string[]): Query;
/**
* @param {string | string[]} [namespaceOrKind] Namespace or kind(s) to query.
* @param {string | string[]} [kind] Kind(s) to query, if namespace is provided as the first argument.
* @returns {Query}
*/
createQuery(
namespaceOrKind?: string | string[],
kind?: string | string[],
Expand Down
Loading