fix: allow filters using false-y but not undefined values or ranges #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the filter code was erroneously omitting filters that checked if a cell value was equal to `0`, as `0` is not truth-y in JS. It is however a valid byte string to check against inside bigtable, so we should still send it along as a filter. This bug applied to both `{value: 0}` exact value filters, or `{value: {start: 0}}` style range filters, and this commit fixes both.
product-auto-label
bot
added
size: m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the filter code was erroneously omitting filters that checked if a cell value was equal to
0, as0is not truth-y in JS. It is however a valid byte string to check against inside bigtable, so we should still send it along as a filter. This bug applied to both{value: 0}exact value filters, or{value: {start: 0}}style range filters, and this commit fixes both.