Skip to content

Commit

Permalink
Fix: TestMutateRow_Generic_Headers (#1540)
Browse files Browse the repository at this point in the history
Mutate rows is grabbing the `appProfileId` from the client. 

https://togithub.com/googleapis/nodejs-bigtable/blob/eb2cd9fb5134e454709b724d99b4da2db9ccadc0/src/tabular-api-surface.ts#L765

We should modify the test proxy test here to do the same.
  • Loading branch information
kevkim-codes authored Dec 16, 2024
1 parent d009a8f commit f6176c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion testproxy/known_failures.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
TestMutateRow_Generic_Headers\|
TestMutateRow_Generic_DeadlineExceeded\|
TestMutateRows_Generic_CloseClient\|
TestMutateRows_Retry_WithRoutingCookie\|
Expand Down
5 changes: 3 additions & 2 deletions testproxy/services/mutate-row.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ const mutateRow = ({clientMap}) =>
normalizeCallback(async rawRequest => {
const {request} = rawRequest;
const {request: mutateRequest} = request;
const {appProfileId, mutations, tableName, rowKey} = mutateRequest;

const {mutations, tableName, rowKey} = mutateRequest;
const {clientId} = request;
const appProfileId = clientMap.get(clientId).appProfileId;
const client = clientMap.get(clientId)[v2];

await client.mutateRow({
appProfileId,
mutations,
Expand Down

0 comments on commit f6176c1

Please sign in to comment.