Skip to content

Commit

Permalink
chore(testproxy): Address the CheckAndMutateRow_Generic_CloseClient c…
Browse files Browse the repository at this point in the history
…onformance test (#1556)

* Attach code to closed client

* Test proxy must send back the result

* Address the known failure

* Add rmrw code back in

* eliminate unnecessary changes

* Pass the code along in the test proxy, not client
  • Loading branch information
danieljbruce authored Dec 20, 2024
1 parent 49c64c5 commit 82ab105
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion testproxy/known_failures.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ TestReadRows_Retry_WithRetryInfo_MultipleErrorResponse\|
TestCheckAndMutateRow_Generic_DeadlineExceeded\|
TestCheckAndMutateRow_NoRetry_TrueMutations\|
TestCheckAndMutateRow_NoRetry_FalseMutations\|
TestCheckAndMutateRow_Generic_CloseClient\|
TestCheckAndMutateRow_Generic_MultiStreams\|
TestSampleRowKeys_Generic_DeadlineExceeded\|
TestSampleRowKeys_Retry_WithRoutingCookie\|
Expand Down
6 changes: 3 additions & 3 deletions testproxy/services/check-and-mutate-row.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ const checkAndMutateRow = ({clientMap}) =>
const filter = [];
const filterConfig = {onMatch, onNoMatch};
try {
const result = await row.filter(filter, filterConfig);
const [, result] = await row.filter(filter, filterConfig);
return {
status: {code: grpc.status.OK, details: []},
row: result,
result,
};
} catch (e) {
return {
status: {
code: e.code,
code: e.code ? e.code : grpc.status.UNKNOWN,
details: [],
message: e.message,
},
Expand Down

0 comments on commit 82ab105

Please sign in to comment.