feat: GH-1375 Improve performance of NetHttpRequest write timeouts by provding a possibility to use custom threadpool #1494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1375, creating a new thread per execution call pretty much kills the performance of application if it's oriented around high write throughput with configured write timeouts.
The proposed solution allows user to provide custom thread executor, so it's now user's responsibility to handle this kind of scenarios and because it doesn't introduce any kind of strange internal cached threadpool, it's also easier to maintain in the future.
Policy
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1375 ☕️