Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1868 ☕️
If you write sample code, please follow the samples format.
Discussion points
This PR extracts the logic that the OpenCensus instrumentation used to instrument an outbound request into an interface that other implementations (Micrometer Observation, OpenTelemetry etc.) could implement. For backward compatibility I left the OpenCensus one as the one that is always being set (you can override it).
Problems
Results of running the tests are
.Metrics
.Spans - Brave
.Spans - OpenTelemetry