Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Micrometer Observation #2044

Open
marcingrzejszczak opened this issue Sep 27, 2023 · 2 comments
Open

Add support for Micrometer Observation #2044

marcingrzejszczak opened this issue Sep 27, 2023 · 2 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@marcingrzejszczak
Copy link

@blakeli0 suggested that I "move" the issue from googleapis/google-http-java-client#1868 (comment) over here.

We're more than happy to add support for instrumenting the Google Http Client with Micrometer Observation. If there's interest we can provide the PRs.

Initial PR to google client - googleapis/google-http-java-client#1879

@blakeli0
Copy link
Collaborator

@marcingrzejszczak Sorry if I didn't make it clear, we can keep all the discussion of adding Micrometer to google-http-java-client as they are. My suggestion was that, if you are interested in adding Micrometer to Google Cloud Client Libraries, this repo is the place to discuss it, and the discussion here would get more attention.

@blakeli0 blakeli0 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 27, 2023
@marcingrzejszczak
Copy link
Author

I see. Anyways, before I file a PR it would be good to know if there's any willingness to have the micrometer observation instrumentation added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants