feat: update build-shared-spanner-lib workflow#752
Conversation
bhatt4982
commented
Feb 17, 2026
- Build windows binaries on ubuntu
- Use ubuntu:20.04 container - forces the binary to link against glibc 2.31
…into Ubuntu and macOS jobs using cross-compilation.
Summary of ChangesHello @bhatt4982, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the build-binaries.sh script to improve cross-compilation capabilities, particularly for building Windows binaries on Ubuntu. The changes also standardize the handling of SKIP_* environment variables for better clarity and consistency, and streamline the build logic for macOS and Linux. The overall changes make the build script more robust and easier to understand. I have one suggestion to further improve the consistency of flag handling.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>