Skip to content

feat: update build-shared-spanner-lib workflow#752

Open
bhatt4982 wants to merge 4 commits intomainfrom
spannerlib-python-workflow
Open

feat: update build-shared-spanner-lib workflow#752
bhatt4982 wants to merge 4 commits intomainfrom
spannerlib-python-workflow

Conversation

@bhatt4982
Copy link
Contributor

  • Build windows binaries on ubuntu
  • Use ubuntu:20.04 container - forces the binary to link against glibc 2.31

@bhatt4982 bhatt4982 requested a review from a team February 17, 2026 07:04
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bhatt4982, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the spannerlib build script to support cross-compilation of Windows binaries on Ubuntu and enforce a specific glibc version for Linux builds. It also refines the conditional logic for platform-specific builds, making the script more robust and explicit in its behavior regarding skipping builds and cross-compilation.

Highlights

  • Windows Binary Build Environment: Configured the build process to enable building Windows binaries from an Ubuntu environment.
  • Glibc Version Control: Ensured that generated binaries link against glibc 2.31 by specifying the ubuntu:20.04 container for builds.
  • Build Script Logic Refinement: Improved the conditional logic for skipping macOS, Linux, and Windows builds, and streamlined the Linux cross-compilation checks.
Changelog
  • spannerlib/shared/build-binaries.sh
    • Added a comment to clarify the go build command.
    • Updated conditional checks for SKIP_MACOS, SKIP_LINUX, and SKIP_WINDOWS environment variables to use a more robust boolean comparison.
    • Modified macOS build section to only attempt building if the current operating system is Darwin.
    • Refactored Linux cross-compilation logic to explicitly check for the x86_64-unknown-linux-gnu-gcc compiler and log skipping if not found or explicitly skipped.
    • Added a comment identifying the standard MinGW compiler name for Windows builds on Ubuntu/Debian.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build-shared-spanner-lib.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@bhatt4982 bhatt4982 changed the title Update build-shared-spanner-lib workflow feat: update build-shared-spanner-lib workflow Feb 17, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the build-binaries.sh script to improve cross-compilation capabilities, particularly for building Windows binaries on Ubuntu. The changes also standardize the handling of SKIP_* environment variables for better clarity and consistency, and streamline the build logic for macOS and Linux. The overall changes make the build script more robust and easier to understand. I have one suggestion to further improve the consistency of flag handling.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments