Respect NDEBUG flag #103
Open
Respect NDEBUG flag #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect NDEBUG flag to build non-debug version of Zopfli.
|
That's nice! I'm seeing 6% speed improvement with |
|
NDEBUG disables all aserts so there are no checks to abort execution when something doesn't go right. I think without this commit and just by issuing -D NDEBUG You should have similar improvement. Though the commit is mainly to finish Lode's TODO thing for ZopfliVerifyLenDist. There were 2 ways to do it, either to just omit insides of ZopfliVerifyLenDist and void typecast its parameters to reduce number of pre-compier checks or to be more concerned about optimal running speed by doing it a bit uglier as in commit. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect NDEBUG flag to build non-debug version of Zopfli.