fix 2-space rule when SPACES_BEFORE_COMMENT is a list #1234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As readme says with
spaces_before_comment="15, 20"
,will be formatted as:
But now the behavior of yapf is formatting it as
The last comment block is preceded by only one space. This condition is also mentioned in #675
I think the bug is caused by the below code in yapf/yapflib/reformatter.py#336
When a value is selected in the
spaces_before_comment
list,aligned_col
will be exactly larger thanmax_line_length
. But when no values are selected,aligned_col
will be not larger thanmax_line_length
. So I modified the later behavior to make them consistent.