[DSLX:TS] Fix issues with type compatibility for parametric signedness params #1864
+229
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arams. There were incompatibilities reported confusingly because the bit widths of the signedness were different; e.g. `u1:0` vs `u32:0` where we don't visually show the width of the signedness when we print in `xN[is_signed=0][8]` sort of form.
cdleary
force-pushed
the
cdleary/2025-01-15-struct-instantiate-xN
branch
from
3bc0400 to
187f707
Compare
meheff
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were incompatibilities reported confusingly because the bit widths of the signedness were different; e.g.
u1:0vsu32:0(note the difference in type bitwidth) where we don't visually show the width of the signedness when we print inxN[is_signed=0][8]sort of form.Note: not sure why but I'm seeing package installation issues with the CI action, e.g. https://github.com/google/xls/actions/runs/12818961097/job/35745586502 around python3-distutils and libtinfo5.
Fixes #1861