added support for source data with multiple time dimensions#340
Open
Piyush-Ingale wants to merge 16 commits intogoogle:mainfrom
Open
added support for source data with multiple time dimensions#340Piyush-Ingale wants to merge 16 commits intogoogle:mainfrom
Piyush-Ingale wants to merge 16 commits intogoogle:mainfrom
Conversation
alxmrs
suggested changes
Jun 12, 2023
Contributor
alxmrs
left a comment
alxmrs
left a comment
There was a problem hiding this comment.
Is there any way that the logic could be a bit simpler?
weather_mv/loader_pipeline/sinks.py
Outdated
| common_dims = set(tiff_config['dims']).intersection(set(ds.dims)) if tiff_config else [] | ||
| dims_map['_'.join(common_dims)].append(ds) | ||
| mdl = [] | ||
| for keys,dsl in dims_map.items(): |
Contributor
There was a problem hiding this comment.
I don't know what's going on here. in this loop. Can you add comments and/or break this up into smaller functions?
Contributor
Author
There was a problem hiding this comment.
I have refactored the code and also added comments
Contributor
|
@Piyush-Ingale: I recommend seeking @deepgabani8's advice (and review) on this PR. In my experience, he has found a few simpler ways to accomplish similar goals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #305
solution is to either create multiple tiff files or store data as bands. So user can specify using
--tiff_configwhich dimensions to consider while generating tiff files. tiff_config will look like this{"dims":["isobaricInhPa"]}By default if time or step dimension is present in source data then it will create multiple tiff files for these dimensions.