Open
Conversation
alxmrs
requested review from
deepgabani8,
j9sh264 and
mahrsee1997
and removed request for
deepgabani8
mahrsee1997
reviewed
Feb 21, 2023
Collaborator
mahrsee1997
left a comment
mahrsee1997
left a comment
There was a problem hiding this comment.
Overall looks good ... just a minor feedback point.
Contributor
Author
|
Thanks for the feedback. The changes are now updated. |
deepgabani8
reviewed
Mar 14, 2023
| raise RuntimeError("Wrong regex passed in --forecast_time_regex.") | ||
| ds.attrs['start_time'] = start_time | ||
| ds.attrs['end_time'] = end_time | ||
| elif 'start_time' in ds.attrs and 'end_time' in ds.attrs: |
Contributor
There was a problem hiding this comment.
3 points
- Our tiff files do not preserve attrs so reading them with
xr.open_dataset(file.tiff, engine='rasterio')will have emptyds.attrs. - 'start_time' and 'end_time' in dataset attrs is in
2021-01-01T00:00:00Zformat so we need to parse it into datetime.datetime() for below datetime_value_s variable to initialize. start_timeis not being used. Can be skipped.
Collaborator
There was a problem hiding this comment.
Good points Deep.
May be we can pick this #159 (comment) next & restructure _preprocess_tif altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and improved codepath for parsing time from Tiffs. Useful for performing round-trip tests.