PR #19649: [ROCm] Implement hermetic rocm dependency #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_705888242
branch
from
beeb36a to
13ab7d7
Compare
Imported from GitHub PR openxla/xla#19649 This change has as a goal to introduce an external dependency to the rocm library and tools. Building xla with the hermetic rocm is done by using these env variables: --repo_env=OS=ubuntu_20.04 --repo_env=ROCM_VERSION=6.2.0 To use only hermetic libs define this flag: --@local_config_rocm//rocm:use_rocm_hermetic_rpath=True This flag will make rpaths and configs to look inside the sandbox If flag is not set then default installation paths are used e.g /opt/rocm One has to provie OS version and ROCm version to initialize a proper rocm repository. If these flags are not set then default ROCm installation will be used to build XLA. depends-on: openxla/xla#19691 Copybara import of the project: -- cf744eca78f697144e122c6a9d1aa8fc52722b20 by Alexandros Theodoridis <[email protected]>: Implement hermetic rocm dependency -- 4f4ad859ec3143fdb04f7792541c61b98c708397 by Alexandros Theodoridis <[email protected]>: Add missing dependency -- 8e164f765b45b5e5d118b02695fd6d6e2b0b232d by Alexandros Theodoridis <[email protected]>: Add missing dependency and remove so files from data -- 35538f4922b5b28b9debd0ce17bb15b83b5921fc by Alexandros Theodoridis <[email protected]>: Rename setting to use_rocm_hermetic_rpath -- 58d140220e9e58572c9a7ae3de2ec1ea189566d3 by Alexandros Theodoridis <[email protected]>: Fix build for cuda and cpu Merging this change closes #19649 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19649 from ROCm:ci_implement_hermetic_rocm_dependency_upstream 58d140220e9e58572c9a7ae3de2ec1ea189566d3 PiperOrigin-RevId: 705888242
copybara-service
bot
force-pushed
the
test_705888242
branch
from
13ab7d7 to
1965e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #19649: [ROCm] Implement hermetic rocm dependency
Imported from GitHub PR openxla/xla#19649
This change has as a goal to introduce an external dependency to the rocm library and tools.
Building xla with the hermetic rocm is done by using these env variables:
--repo_env=OS=ubuntu_20.04
--repo_env=ROCM_VERSION=6.2.0
To use only hermetic libs define this flag:
--@local_config_rocm//rocm:use_rocm_hermetic_rpath=True
This flag will make rpaths and configs to look inside the sandbox
If flag is not set then default installation paths are used e.g /opt/rocm
One has to provie OS version and ROCm version to initialize a proper rocm repository.
If these flags are not set then default ROCm installation will be used to build XLA.
depends-on: openxla/xla#19691
Copybara import of the project:
--
cf744eca78f697144e122c6a9d1aa8fc52722b20 by Alexandros Theodoridis [email protected]:
Implement hermetic rocm dependency
--
4f4ad859ec3143fdb04f7792541c61b98c708397 by Alexandros Theodoridis [email protected]:
Add missing dependency
--
8e164f765b45b5e5d118b02695fd6d6e2b0b232d by Alexandros Theodoridis [email protected]:
Add missing dependency and remove so files from data
--
35538f4922b5b28b9debd0ce17bb15b83b5921fc by Alexandros Theodoridis [email protected]:
Rename setting to use_rocm_hermetic_rpath
--
58d140220e9e58572c9a7ae3de2ec1ea189566d3 by Alexandros Theodoridis [email protected]:
Fix build for cuda and cpu
Merging this change closes #19649
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19649 from ROCm:ci_implement_hermetic_rocm_dependency_upstream 58d140220e9e58572c9a7ae3de2ec1ea189566d3