Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/UI/material3 theme #966

Open
wants to merge 79 commits into
base: dev
Choose a base branch
from
Open

Feature/UI/material3 theme #966

wants to merge 79 commits into from

Conversation

sofyakurilova
Copy link
Collaborator

No description provided.

sofyakurilova and others added 30 commits October 30, 2024 11:26
@sofyakurilova
Migrate to material 3
403bbc2
@sofyakurilova
Adds copyright
056c2b6
@sofyakurilova
Apply new styles for reports table
7fcf7b5
@sofyakurilova
Fix color
99ea934
@OlgaMardvilko
378065444: (feat) apply gm3 for header (#965)
e3f52a3
@sofyakurilova
Merge branch 'dev' into feature/ui/material3_theme
df65016
@sofyakurilova
Merge branch 'dev' into feature/ui/material3_theme
1e9f54f
@sofyakurilova
Increase budget
a8adfe7
@sofyakurilova
Adds color palette
2249cc4
@sofyakurilova
Fix lint issues
80326ca
@sofyakurilova
Make palette private
2eadcb8
@sofyakurilova
Remove unused import
0030e4f
@sofyakurilova
Fix sorting icon on hover
e374c0b
@sofyakurilova
Adds aria-label and hover styles
c764435
@sofyakurilova
Change import from 'src/theming/...' to '...'
e774cb4
@sofyakurilova
Fix linter issues
b8e7229
@sofyakurilova
Fix imports
875c456
@sofyakurilova
Fix tests
1c3a963
@OlgaMardvilko
378065443: (feat) add gm3 for nav bar (#971)
ab38510 
* 378065443: (feat) add gm3 for nav bar

* 378065443: (feat) add gm3 for nav bar
@OlgaMardvilko
379246727: (fix) changes for gm3 header (#973)
64a08f8
@sofyakurilova
Merge branch 'dev' into feature/ui/material3_theme
1a885e0 
# Conflicts:
#	modules/ui/angular.json
@sofyakurilova
Merge branch 'dev' into feature/ui/material3_theme
286a2bc
@OlgaMardvilko
379246727: (fix) change certificate button to filled view (#980)
d1fb1da
@sofyakurilova
Adds style for focused logo
88d21cd
@sofyakurilova
Adds style for better spacing between elements
d6136b8
@sofyakurilova
Fix focus style; adds focus after redirect
a0712ba
@sofyakurilova
Merge branch 'dev' into feature/ui/material3_theme
776a162
@sofyakurilova
Update version
fb74610
@sofyakurilova
Update version
b11ef4e
@sofyakurilova
Fix tests
d3ad6db
@jboddey
Copy link
Collaborator

jboddey commented Jan 2, 2025

Some findings from the branch so far:

  • Settings page: If the selected port is missing (resulting in two callouts at the top), then the save button on the settings page cannot be reached at 100% page zoom.
  • Certificates settings: The page is cut off at the bottom when in 100% zoom.
  • Device modal. Cannot edit a device. Always get the error: 'A device with that MAC address already exists'

Other non-blocking issues:

  • The device edit modal is very blue. No spacing between testing journey type and the icon.

sofyakurilova and others added 17 commits January 2, 2025 10:38
@sofyakurilova
Change border color for warning callout; change icon for error callouts
ba5badb
@OlgaMardvilko
386919467: (fix) make internet port disable in single mode after enab…
10a58d3 
…le form (#1040)
@OlgaMardvilko
387242682: (fix) make save button available on the settings page with…
4611a28 
… callouts (#1042)
@OlgaMardvilko
387242169: (fix) change availability of certificate page (#1045)
a9135b0
@OlgaMardvilko
387242169: (fix) change scroll on settings (#1049)
a1d2d45
@OlgaMardvilko
387242169: (fix) change scroll on settings (#1049)
95ddf54
@sofyakurilova
Device form (#1046)
a6a1493 
* BE: Changes format for devices/format
FE: Form has no pages; form opens on button click.

Device actions is out of scope.

* Fix tests

* Fix tests
@OlgaMardvilko
387461943: (fix) remove double scroll on device page (#1051)
2391c1e
@OlgaMardvilko
385169773: (feat) add devices input form (#1054)
1aaadbc
@sofyakurilova
Reset form values for new device
5d3c1c0
@sofyakurilova
Reset form to default values
92899aa
@sofyakurilova
Fix test
a599951
@sofyakurilova
Disable 3 dots menu for device under test; adds status for device und…
e02289c 
…er test
@sofyakurilova
Disable save button when devices has no changes or invalid; disable c…
471a105 
…ancel button when device has no changes; disable delete button for new device
@sofyakurilova
Adds dialog when switching the device and there are unsaved changes
9d08010
@sofyakurilova
Adds tests
5e3d7af
@sofyakurilova
Change dialog width
f74c35d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofyakurilova @jboddey @OlgaMardvilko