Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required result table column #1066

Merged
merged 19 commits into from
Jan 22, 2025

Conversation

hitnik
Copy link
Collaborator

@hitnik hitnik commented Jan 17, 2025

pilot report example (rename pdf to html)
report.html.pdf

@hitnik hitnik requested a review from sofyakurilova January 17, 2025 15:57
@jboddey
Copy link
Collaborator

jboddey commented Jan 17, 2025

We might as well have the required result column for both pilot and qualification reports. Could you also shift it over to 7in from the left @hitnik?

@MariusBaldovin could you look at fixing the API tests? They shouldn't have broken.

@MariusBaldovin
Copy link
Collaborator

We might as well have the required result column for both pilot and qualification reports. Could you also shift it over to 7in from the left @hitnik?

@MariusBaldovin could you look at fixing the API tests? They shouldn't have broken.

Updated the report

We might as well have the required result column for both pilot and qualification reports. Could you also shift it over to 7in from the left @hitnik?

@MariusBaldovin could you look at fixing the API tests? They shouldn't have broken.

The issue was that the 'test_pack' key was missing in the report used for testing. The report has now been updated.

@sofyakurilova sofyakurilova requested review from jboddey and MariusBaldovin and removed request for sofyakurilova January 21, 2025 12:24
@hitnik
Copy link
Collaborator Author

hitnik commented Jan 21, 2025

@sofyakurilova
report_example.pdf

Signed-off-by: Sofia Kurilova <[email protected]>
Signed-off-by: Sofia Kurilova <[email protected]>
@hitnik
Copy link
Collaborator Author

hitnik commented Jan 21, 2025

@hitnik
Copy link
Collaborator Author

hitnik commented Jan 22, 2025

@hitnik
Copy link
Collaborator Author

hitnik commented Jan 22, 2025

Copy link
Collaborator

@OlgaMardvilko OlgaMardvilko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hitnik hitnik merged commit f7b1175 into feature/384032243-pilot-report Jan 22, 2025
16 checks passed
@hitnik hitnik deleted the feature/pilot_result_table branch January 22, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants