-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/9955 post meta settings class #9999
Conversation
Build files for 53437b8 have been deleted. |
Size Change: +42 B (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, @ankitrox!
I've added a few very minor nitpicky comments for you to review. Besides, could you also update the branch and resolve commits?
Please let me know if you have any questions, thank you!
tests/phpunit/integration/Modules/Reader_Revenue_Manager/Post_Product_ID_Test.php
Outdated
Show resolved
Hide resolved
tests/phpunit/integration/Modules/Reader_Revenue_Manager/Post_Product_ID_Test.php
Outdated
Show resolved
Hide resolved
Thanks for reviewing the PR @nfmohit and adding the feedback. I've addressed the feedback comments and sending it your way to further review the changes. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, nice work, LGTM ✅
Note: I've verified that the failing E2E tests in CI are unrelated to the PR.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist