Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/9955 post meta settings class #9999

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

ankitrox
Copy link
Collaborator

@ankitrox ankitrox commented Jan 9, 2025

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jan 9, 2025

Build files for 53437b8 have been deleted.

Copy link

github-actions bot commented Jan 9, 2025

Size Change: +42 B (0%)

Total Size: 1.99 MB

Filename Size Change
./dist/assets/js/googlesitekit-datastore-user-********************.js 28.2 kB +1 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.4 kB +25 B (+0.03%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 166 kB +10 B (+0.01%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 119 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 191 kB -5 B (0%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 43.2 kB +14 B (+0.03%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 69.1 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 62.2 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.44 kB
./dist/assets/js/33-********************.js 2.76 kB
./dist/assets/js/34-********************.js 2.25 kB
./dist/assets/js/35-********************.js 3.64 kB
./dist/assets/js/36-********************.js 936 B
./dist/assets/js/37-********************.js 892 B
./dist/assets/js/38-********************.js 1.61 kB
./dist/assets/js/39-********************.js 1.57 kB
./dist/assets/js/40-********************.js 1.61 kB
./dist/assets/js/41-********************.js 1.59 kB
./dist/assets/js/42-********************.js 1.83 kB
./dist/assets/js/43-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-activation-********************.js 24 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.1 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.8 kB
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.17 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.97 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.2 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-metric-selection-********************.js 52.1 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.4 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 35.8 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 31.2 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.4 kB
./dist/assets/js/googlesitekit-notifications-********************.js 37 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/googlesitekit-settings-********************.js 127 kB
./dist/assets/js/googlesitekit-splash-********************.js 68.7 kB
./dist/assets/js/googlesitekit-user-input-********************.js 43.9 kB
./dist/assets/js/googlesitekit-vendor-********************.js 324 kB
./dist/assets/js/googlesitekit-widgets-********************.js 102 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 63.2 kB
./dist/assets/js/runtime-********************.js 1.4 kB

compressed-size-action

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this, @ankitrox!

I've added a few very minor nitpicky comments for you to review. Besides, could you also update the branch and resolve commits?

Please let me know if you have any questions, thank you!

@ankitrox
Copy link
Collaborator Author

Thanks for reviewing the PR @nfmohit and adding the feedback.

I've addressed the feedback comments and sending it your way to further review the changes.

Thanks again!

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, nice work, LGTM ✅

Note: I've verified that the failing E2E tests in CI are unrelated to the PR.

@nfmohit nfmohit merged commit d5100bd into develop Jan 14, 2025
18 of 20 checks passed
@nfmohit nfmohit deleted the enhancement/9955-post-meta-settings-class branch January 14, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants