Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extra environment args provided with the run_clusterfuzzlite command where not being used #12439

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

4kreed
Copy link

@4kreed 4kreed commented Sep 2, 2024

Hi there 👋 ,

this is my very first contribution to this project so please let me know if there is anything that I should do differently.

The goal of this small PR is to allow the user that the extra environment arguments that they can provide to the run_clusterfuzzlite command are actually used (before this change the user could provide them but they were not used).

How to reproduce the problem

  1. For this example we will be using cifuzz-example, which can be downloaded from https://github.com/jonathanmetzman/cifuzz-example into /path/to/cifuzz-example
  2. cd /path/to/cifuzz-example
  3. mkdir .clusterfuzzlite
  4. cp /path/to/oss-fuzz/projects/cifuzz-example/build.sh .clusterfuzzlite/
  5. cp /path/to/oss-fuzz/projects/cifuzz-example/Dockerfile .clusterfuzzlite/
  6. Modify .clusterfuzzlite/Dockerfile such that the last line of the file becomes COPY .clusterfuzzlite/build.sh $SRC/ (instead of COPY build.sh $SRC/)
  7. Run python3 /path/to/oss-fuzz/infra/helper.py run_clusterfuzzlite --external --branch master -e SANITIZER=coverage /path/to/cifuzz-example

In this scenario you could see that the SANITIZER=coverage environment argument is not being used.

Thanks in advance for your time.

Copy link

google-cla bot commented Sep 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@4kreed 4kreed marked this pull request as draft September 2, 2024 16:48
@4kreed 4kreed marked this pull request as ready for review September 2, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant