fixing broken rdkit build by using Release_2024_03_5 and updating boo… #12399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
th3lsh3ll is a new contributor to projects/rdkit. The PR must be approved by known contributors before it can be merged. The past contributors are: DonggeLiu, greglandrum, devtty1er, inferno-chromium, intrigus |
|
Hi @greglandrum, would this look good to you? |
I think that it would be better to get the master builds working, right? If we limit this to one particular release then any fixes that get made upstream will not show up here. Or am I missing something? |
|
Ok makes sense. It was for temporary until the updated branch build got fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDKit has been broken for fuzzing and reproducing
Changing the version to the last stable release and the build.sh to fix a compilation error fixes the build