Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inital Project Skeleton fpdf2 #12046

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ennamarie19
Copy link
Contributor

Approval from upstream can be found here: py-pdf/fpdf2#1195

Copy link

ennamarie19 is integrating a new project:
- Main repo: https://github.com/py-pdf/fpdf2.git
- Criticality score: 0.56764

@Lucas-C
Copy link

Lucas-C commented Jun 13, 2024

As a maintainer of fpdf2, I approve this PR.
Thank you @ennamarie19!

@DonggeLiu
Copy link
Contributor

Thanks @ennamarie19
May I ask who the major users of the project are and why it is critical?
This will help the panel approve this PR.

@Lucas-C
Copy link

Lucas-C commented Jul 5, 2024

For the record, we keep a list of "dependent/downstream projects" of fpdf2 there: https://py-pdf.github.io/fpdf2/#they-use-fpdf2

Another list of dependent packages is provided by Wheelodex there: https://www.wheelodex.org/projects/fpdf2/rdepends/

@ennamarie19
Copy link
Contributor Author

ennamarie19 commented Jul 5, 2024

Thank you @Lucas-C! @DonggeLiu please see those links :)

@DonggeLiu
Copy link
Contributor

Thanks! I will approve this PR once the panel decides so.

@ennamarie19
Copy link
Contributor Author

Thanks! I will approve this PR once the panel decides so.

@DonggeLiu hey there! Has the panel had a chance to review this yet?

@DonggeLiu
Copy link
Contributor

Thanks! I will approve this PR once the panel decides so.

@DonggeLiu hey there! Has the panel had a chance to review this yet?

Would you mind considering ClusterFuzzLite instead?

@ennamarie19
Copy link
Contributor Author

Thanks! I will approve this PR once the panel decides so.

@DonggeLiu hey there! Has the panel had a chance to review this yet?

Would you mind considering ClusterFuzzLite instead?

May I ask why that instead? This repo seems to meet the usual criteria for accepted OSS-Fuzz projects.

@DonggeLiu
Copy link
Contributor

Thanks! I will approve this PR once the panel decides so.

@DonggeLiu hey there! Has the panel had a chance to review this yet?

Would you mind considering ClusterFuzzLite instead?

May I ask why that instead? This repo seems to meet the usual criteria for accepted OSS-Fuzz projects.

Sure, two main reasons:

  1. It has a limited number of critical users
  2. It's Python-only.

@ennamarie19
Copy link
Contributor Author

ennamarie19 commented Aug 29, 2024 via email

@DonggeLiu
Copy link
Contributor

So if a repo has more critical users but is just Python, would it be accepted? Or are Python repos not being accepted anymore?

Python projects may be accepted, depending on the users and the nature of the project (e.g., use C/C++ native extensions hence may have memory corruption).
The panel reviews them case by case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants