ion-java: update CCs to include project maintainers and increase verbosity of build logs. #11892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tgregg
commented
May 2, 2024
tgregg
commented
- Replace current CCs with the project maintainers.
- Add more info to the build to make errors easier to diagnose.
…osity of build logs.
|
tgregg has previously contributed to projects/ion-java. The previous PR was #11586 |
popematt
approved these changes
May 2, 2024
|
What do we need to do to get this merged? |
oliverchang
approved these changes
Jan 7, 2025
|
Merging this, though it looks like the build is still failing. |
|
Yes, that's expected. It was already failing for some reason, and we were trying to increase the verbosity of the logging so that it will be easier to figure out why the build is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.