Fix incorrect size check in NFGenMsg #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rules in monitor
|
Would it be possible to add a test case for this issue? (If it’s too hard to craft such a test, that’s probably okay, I just figured I’d ask.) |
|
@stapelberg tomorrow I will check 👍 |
|
@stapelberg done ;) |
stapelberg
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves an issue with the size check in
NFGenMsg.Currently, the size is truncated to 4 bytes, but the check incorrectly expects 16 bytes. As a result,
NFGenMsg.Decodeis never executed.You can find the relevant code here:
nftables/monitor.go
Line 375 in 51c44dc
This fix ensures that NFGenMsg is decoded correctly.