Improve coeffecients for FastTanh using CF approximation.#2888
Merged
copybara-service[bot] merged 1 commit intomasterfrom Feb 27, 2026
Merged
Improve coeffecients for FastTanh using CF approximation.#2888copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
Max relative error drops from 0.13% to 0.08%. Average relative error drops from 0.003% to 0.0007%. Also removed arr_b and its logic handling since it is always 1.0 shaving off some instruction count. PiperOrigin-RevId: 876167894
copybara-service
bot
force-pushed
the
test_875854987
branch
from
1b5b33c to
5d0d33a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve coeffecients for FastTanh using CF approximation.
Max relative error drops from 0.13% to 0.08%.
Average relative error drops from 0.003% to 0.0007%.
Also removed arr_b and its logic handling since it is always 1.0 shaving off some instruction count.