Add shortest path, critical path also and some affordances to Graph template #1149
Conversation
…troduce weighted graph
ai-mannamalai
force-pushed
the
ma-120524-graphalgo
branch
from
52cccfe to
4d47d3d
Compare
| @@ -64,6 +74,66 @@ class Graph { | |||
| return {}; | |||
| } | |||
|
|
|||
| FailureOr<std::vector<V>> get_longest_source_to_sink_path() { | |||
There was a problem hiding this comment.
nit - could you please camelcake the new functions to match the general code style?
There was a problem hiding this comment.
It's interesting that the formatting checks don't complain about this...
PS: typos + GenAI are a magical combination:
| @@ -148,10 +218,109 @@ class Graph { | |||
| return output; | |||
| } | |||
|
|
|||
| /* get vertices in graph with 0 incoming edges */ | |||
There was a problem hiding this comment.
you can use llvm::copy_if(vertices, [V& v vertex] { return getInEdges(v) == 0; }) if you want!
|
|
||
| /* get number of incoming edges into vertex */ | ||
| uint64_t get_in_degree(V vertex) { | ||
| return inEdges.count(vertex) ? 0 : inEdges.at(vertex).size(); |
| if (result.empty() || result.size() < 3) return result; | ||
| std::vector<V> cp_result; | ||
| // first node has to be a source node | ||
| if (std::find(sources.begin(), sources.end(), result.at(0)) == |
There was a problem hiding this comment.
here you can also use the llvm STL helpers (llvm::find(sources, result.at(0))
There was a problem hiding this comment.
Thanks for upstreaming this! I'm unfortunately not really familiar with these utils and what they're used for (thanks @asraa for reviewing!), so a little dummy example/usecase would be super cool (only if you have the time, otherwise it'll just go on the increasingly long pile of "things we should write more documentation for" 😉)
|
The graph utilities are currently mainly used for our custom circuit vectorizer. We lay out the circuit gates in "levels" according to the dependency graph, and then process the gates in each level as a batch in parallel. I agree this contribution looks good, but I'd want to know more about what it's planned to be used for, and to see some tests of the new routines to help ensure correctness. |
|
Fair enough - @AlexanderViand-Intel - I will add some unit tests. Need more time for this. |
Add shortest path, critical path also and some affordances to Graph template