Skip to content

Conversation

@bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Sep 17, 2025

This is the result of running the following from discoveryapis_generator:

dart bin/generate.dart package -i ../discovery-artifact-manager/discoveries -o ../generated/googleapis

In order to get this to run successfully, I need to make an update to generateAllLibraries in discoveryapis_generator/lib/discoveryapis_generator.dart to handle cases where a RestDescription could not be generated from a json file (I believe this only applied to index.json)

This also updates the version to 15.0.0. I'm not sure if there's a way to automate the changelog update, but I'd like to be sure that the discovery json files I used as input are up-to-date before proceeding (as per the readme, they are "updated by an internal mechanism and cannot be run locally at this time.")

@bryanoltman bryanoltman changed the title Update pubsub/v1.dart to reflect latest schema Update generated code to reflect latest schema Sep 17, 2025
@bryanoltman
Copy link
Contributor Author

Update: changing this to a draft, as it seems like shared.dart is referencing types (BlogLocale, BlogPages, etc.) from files that depend on it.

@bryanoltman bryanoltman marked this pull request as draft September 17, 2025 15:44
@kevmoo
Copy link
Collaborator

kevmoo commented Sep 17, 2025

there are scripts in the root tools directory for this.

@kevmoo
Copy link
Collaborator

kevmoo commented Sep 17, 2025

I can take care of it. It's not well documented. Are there changes you really want soon?

@bryanoltman
Copy link
Contributor Author

@kevmoo that would be awesome. I'll check out the scripts in the meantime. The motivation for doing this was to make the pubsub Message type's orderingKey available.

@bryanoltman
Copy link
Contributor Author

Looked at the tool directory and ran ./tool/download.sh and ./tool/local_rebuild.sh, and that looks like it worked.

It seems to have updated almost every json file though, so I'm not sure if it makes sense to call them out all individually in the changelog (or if there's an automated way to make sense of ~150 changed json files)?

@bryanoltman
Copy link
Contributor Author

Closing in favor of #688

@bryanoltman bryanoltman deleted the bo/update-pubsubv1 branch September 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants