Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FindDependencies to optionally follow symlinks #730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thequailman
Copy link

I am using the FindDependencies function in this library to gather jsonnet files for future rendering. The current implementation of getAbsPath follows symlinks, which makes it very hard to determine later on what the file path should be when using a custom Importer. This change adds a flag to getAbsPath to make the symlink resolution optional. jsonnet-deps will still follow symlinks/there should be no behavior change for users.

@google-cla
Copy link

google-cla bot commented Sep 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant