Skip to content

fix(core): add title to simulate method and unify telemetry data #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyMarkinPPC merged 1 commit into from
Jan 31, 2026
Merged

fix(core): add title to simulate method and unify telemetry data #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libs/core/garf/core/simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

import pydantic
from garf.core import api_clients, exceptions, parsers, query_editor, report
from garf.core.telemetry import tracer
from opentelemetry import trace

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -63,11 +65,13 @@ def __init__(
self.query_specification_builder = query_specification_builder
self.simulator_specification_builder = simulator_specification_builder

@tracer.start_as_current_span('simulate')
def simulate(
self,
query_specification: str | query_editor.QuerySpecification,
simulator_specification: SimulatorSpecification | None = None,
args: query_editor.GarfQueryParameters | None = None,
title: str | None = None,
**kwargs: str,
) -> report.GarfReport:
if args is None:
Expand All @@ -78,7 +82,13 @@ def simulate(
args=args,
**kwargs,
)
span = trace.get_current_span()
query = query_specification.generate()
if not query.title:
query.title = title
if query.title:
span.set_attribute('query.title', query.title)
span.set_attribute('query.text', query.text)
try:
response_types = self.api_client.get_types(query, **kwargs)
except NotImplementedError as e:
Expand Down