Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Upgrade to Flutter 2 and null-safety #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

f-person
Copy link

@f-person f-person commented Oct 13, 2021

I migrated the code base (package, tests, example) to Flutter 2 and null-safety.

@google-cla
Copy link

google-cla bot commented Oct 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@f-person
Copy link
Author

@googlebot I signed it!

@f-person
Copy link
Author

I understand that this package is not recommended for use now but there are apps that are migrating to null safety but still didn't migrate from flutter_flux. So I think the migration process will be easier if a null-safe package is available on pub.dev.

@rxlabz @jimbeveridge @AndreHaueisen @Hixie can you please take a look at this PR?

@Hixie
Copy link
Contributor

Hixie commented Dec 1, 2021

LGTM, but I'm not an owner on this repo so I'm afraid my review means nothing.

@jimbeveridge
Copy link
Contributor

Hi @Hixie. I was the owner of this repo before I left Google, but it doesn't look like I have approval permission anymore. This looks like a valuable PR - can someone else take over as owner so this PR can be approved?

@Hixie
Copy link
Contributor

Hixie commented Dec 8, 2021

@jimbeveridge would you like to continue being owner? i can see if we can give you rights again.

@jimbeveridge
Copy link
Contributor

@Hixie SGTM.

@Hixie
Copy link
Contributor

Hixie commented Dec 9, 2021

@jimbeveridge I spoke to OSPO and they suggested the best course of action is for you to fork the repo and maintain it there, and then for us to archive this one. Would that work for you?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants