Open
Conversation
jtdavis777
added
the
ready-for-merge
aardappel
reviewed
Feb 5, 2026
| private: | ||
| std::set<std::string> file_names_{}; | ||
| }; | ||
| std::unique_ptr<FileSaver> CreateFileSaver(); |
Collaborator
There was a problem hiding this comment.
These kind of helper functions don't seem necessary to me.
Collaborator
There was a problem hiding this comment.
Ah ok I guess they're needed because of the inheritance.
In that case this is all boilerplate, and I don't have a lot of opinions on what is the nicest boilerplate. I would pick whatever the simplest code is :)
| bool binary) final { | ||
| std::ofstream ofs{name, | ||
| binary ? std::ofstream::binary : std::ofstream::out}; | ||
|
|
Collaborator
There was a problem hiding this comment.
Remove all these empty lines here and elsewhere, this is not in the style of the rest of the codebase and the google styleguide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussion with @dbaileychess, I have moved the concrete instance definitions of FileSaver into the cpp files which define them.
Fixes #8902 as well