fix fragment/vertex shader descriptor set layout mismatch #8140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SSR variant uses a custom fragment shader but the generic vertex shader. For this reason their descriptor set layout for the "per view" set end-up being different (the fragment shader one has less descriptors in it and the descriptor itself is create from the SSR variant data). In the end, we end up with a descriptor set that's too small for the vertex shader and Metal was rightly complaining. We fix this by: - removing the descriptors unused in the vertex shader in the generic case - adding the remaining descriptors in the SSR version of the layout In practice this only adds one UBO (for shadows). That UBO is actually not even used in the SSR variants, but the (generic) vertex shader layout has it, so it must be provided. WE do this by providing a dummy UBO, which will never be used anyways. In addition, we add a check to matc which will make sure such mismatch won't happen again.
poweifeng
approved these changes
Sep 19, 2024
Co-authored-by: Powei Feng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSR variant uses a custom fragment shader but the generic vertex shader. For this reason their descriptor set layout for the "per view" set end-up being different (the fragment shader one has less descriptors in it and the descriptor itself is create from the SSR variant data). In the end, we end up with a descriptor set that's too small for the vertex shader and Metal was rightly complaining.
We fix this by:
In practice this only adds one UBO (for shadows). That UBO is actually not even used in the SSR variants, but the (generic) vertex shader layout has it, so it must be provided. WE do this by providing a dummy UBO, which will never be used anyways.
In addition, we add a check to matc which will make sure such mismatch won't happen again.