-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for area lights #8020
base: ma/descriptor-sets
Are you sure you want to change the base?
Conversation
it will take a little while to review. thank you for the contribution. |
I'll take a look as well but I've explored LTC before and burning 2 samplers is most likely a no-go on mobile for us (plus the question of the binary size increase). There are other concerns I'll need to detail as well (the way this is written there will be an extra cost for all lights even non area lights which isn't something we want to pay for on mobile). |
A few comments echoing Romain's:
|
I apologize for the confusion. I accidentally marked this PR as ready for review and have now converted it back to draft status. I appreciate the feedback from @pixelflinger. I'll be working on addressing the following points:
As I'm balancing this with my full-time job, updates may take some time. I'll do my best to work on these changes as efficiently as possible, but please understand if progress is not immediate. I'll update the PR once these changes are implemented. Thank you for your patience, understanding, and input. |
2d8070d
to
e064cb8
Compare
e064cb8
to
6086659
Compare
6086659
to
ed3ece8
Compare
I've updated this PR with the following changes:
Next, I'm trying to restrict this feature to only work with feature level 3. However, I'm not yet fully familiar with the codebase and I'm unsure which parts need to be modified. Could you provide some guidance or a starting point on how to properly restrict this feature to feature level 3 and handle lower feature levels? |
This pull request introduces area light support in Filament, focusing primarily on rectangle lights. The implementation draws inspiration from Eric Heitz et al.'s "Real-Time Polygonal-Light Shading with Linearly Transformed Cosines" research (ACM SIGGRAPH 2016, https://eheitzresearch.wordpress.com/415-2/) and the approach used in Three.js.
In developing this feature, I prioritized smooth integration with Filament's existing lighting system over performance optimization.
I'm open to feedback and suggestions for improving this implementation. Thank you for reviewing my contribution to the Filament project.