-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix javascript example #921
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The super simple fix in #737 (comment) should work too, but I think modern ES class makes it easier to read. |
Thanks you for the PR! Unfortunately, the present plan is to remove the example from our next release. The example will be replace with a link to the three.js docs and example. |
Actually: change of plans. We will be updating the example, but I won't be able to get to this PR right away. Thanks for your patience! |
@jokester When you have the time, can you rebase and push an updated patch? Thanks! |
THREE.Loader is a ES class now and have to be subclassed like this
636e031
to
e525937
Compare
@tomfinegan Sure. Just rebased my commits to latest |
THREE.Loader
to use ES class (this should fix Unable to run the example application #737 )REPO/javascript/name
will have URL path/javascript/name