Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javascript example #921

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jokester
Copy link

@jokester jokester commented Aug 31, 2022

  1. Follow upstream THREE.Loader to use ES class (this should fix Unable to run the example application  #737 )
  2. set decoder path to load draco assets properly (if we follow javascript/README to set up a http server, assets in REPO/javascript/name will have URL path /javascript/name

@google-cla
Copy link

google-cla bot commented Aug 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jokester
Copy link
Author

The super simple fix in #737 (comment) should work too, but I think modern ES class makes it easier to read.

@tomfinegan
Copy link
Contributor

Thanks you for the PR!

Unfortunately, the present plan is to remove the example from our next release. The example will be replace with a link to the three.js docs and example.

@tomfinegan
Copy link
Contributor

Thanks you for the PR!

Unfortunately, the present plan is to remove the example from our next release. The example will be replace with a link to the three.js docs and example.

Actually: change of plans. We will be updating the example, but I won't be able to get to this PR right away. Thanks for your patience!

@tomfinegan
Copy link
Contributor

@jokester When you have the time, can you rebase and push an updated patch? Thanks!

@jokester jokester force-pushed the fix-javascript-example branch from 636e031 to e525937 Compare March 17, 2023 15:28
@jokester
Copy link
Author

@tomfinegan Sure. Just rebased my commits to latest master. The fix should still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run the example application
2 participants