Skip to content

Commit

Permalink
Add assert and test.
Browse files Browse the repository at this point in the history
  • Loading branch information
floitschG committed Mar 4, 2017
1 parent 1921cb3 commit 78cd7b1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions double-conversion/fixed-dtoa.cc
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ static void FillFractionals(uint64_t fractionals, int exponent,
fractionals -= static_cast<uint64_t>(digit) << point;
}
// If the first bit after the point is set we have to round up.
ASSERT(fractionals == 0 || point - 1 >= 0);
if ((fractionals != 0) && ((fractionals >> (point - 1)) & 1) == 1) {
RoundUp(buffer, length, decimal_point);
}
Expand Down
4 changes: 4 additions & 0 deletions test/cctest/test-fixed-dtoa.cc
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,10 @@ TEST(FastFixedVariousDoubles) {
buffer, &length, &point));
CHECK_EQ("1000000000000000128", buffer.start());
CHECK_EQ(19, point);

CHECK(FastFixedDtoa(2.10861548515811875e+15, 17, buffer, &length, &point));
CHECK_EQ("210861548515811875", buffer.start());
CHECK_EQ(16, point);
}


Expand Down

0 comments on commit 78cd7b1

Please sign in to comment.