Update XTypes#isWildcard() call to use the new XType#isStar() function.
#5048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_840762725
branch
2 times, most recently
from
b7253bd to
ddc0edf
Compare
…ction. `XTypes#isWildcard()` previously converted a type to `XTypeName` to determine if the given type is a wildcard type. However, calculating `XTypeName` is expensive, so I've migrated to using the new function `XType#isStar()` to determine if the type is a wildcard type. RELNOTES=N/A PiperOrigin-RevId: 842304555
copybara-service
bot
force-pushed
the
test_840762725
branch
from
ddc0edf to
fb2eed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
XTypes#isWildcard()call to use the newXType#isStar()function.XTypes#isWildcard()previously converted a type toXTypeNameto determine if the given type is a wildcard type. However, calculatingXTypeNameis expensive, so I've migrated to using the new functionXType#isStar()to determine if the type is a wildcard type.RELNOTES=N/A