Skip to content

Add a synthetic dependency from golden tests to the matching Crubit binary#427

Merged
copybara-service[bot] merged 1 commit intomainfrom
test_866608570
Feb 6, 2026
Merged

Add a synthetic dependency from golden tests to the matching Crubit binary#427
copybara-service[bot] merged 1 commit intomainfrom
test_866608570

Conversation

@copybara-service
Copy link

@copybara-service copybara-service bot commented Feb 6, 2026

Add a synthetic dependency from golden tests to the matching Crubit binary

This lets us revert the hack from 73b130f because Blaze should correctly invalidate its cached results for golden tests when Crubit tool code changes.

Demo queries, all of which return empty results before this change

cc_bindings_from_rs:

$ blaze query 'somepath(//third_party/crubit/cc_bindings_from_rs/test/golden:type_aliases_test, //third_party/crubit/cc_bindings_from_rs/generate_bindings/database)'

//third_party/crubit/cc_bindings_from_rs/test/golden:type_aliases_test
//third_party/crubit/cc_bindings_from_rs/test/golden:type_aliases.h_file
//third_party/crubit/cc_bindings_from_rs/test/golden:type_aliases.generated_bindings
//third_party/crubit/cc_bindings_from_rs:cc_bindings_from_rs
//third_party/crubit/cc_bindings_from_rs:cc_bindings_from_rs_without_forced_build_flavor
//third_party/crubit/cc_bindings_from_rs/generate_bindings:generate_bindings
//third_party/crubit/cc_bindings_from_rs/generate_bindings/database:database

The C++ side of rs_bindings_from_cc:

$ blaze query 'somepath(//third_party/crubit/rs_bindings_from_cc/test/golden:callables_test, //third_party/crubit/rs_bindings_from_cc/importers:function)'

//third_party/crubit/rs_bindings_from_cc/test/golden:callables_test
//third_party/crubit/rs_bindings_from_cc/test/golden:callables.cc_file
//third_party/crubit/rs_bindings_from_cc/test/golden:callables.generated_bindings
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc_main
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc_main_without_forced_build_flavor
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc_impl
//third_party/crubit/rs_bindings_from_cc:generate_bindings_and_metadata
//third_party/crubit/rs_bindings_from_cc:ir_from_cc
//third_party/crubit/rs_bindings_from_cc:frontend_action
//third_party/crubit/rs_bindings_from_cc:ast_consumer
//third_party/crubit/rs_bindings_from_cc:importer
//third_party/crubit/rs_bindings_from_cc/importers:function

The Rust side of rs_bindings_from_cc:

$ blaze query 'somepath(//third_party/crubit/rs_bindings_from_cc/test/golden:callables_test, //third_party/crubit/rs_bindings_from_cc/generate_bindings:generate_function)'

//third_party/crubit/rs_bindings_from_cc/test/golden:callables_test
//third_party/crubit/rs_bindings_from_cc/test/golden:callables.cc_file
//third_party/crubit/rs_bindings_from_cc/test/golden:callables.generated_bindings
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc_main
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc_main_without_forced_build_flavor
//third_party/crubit/rs_bindings_from_cc:rs_bindings_from_cc_impl
//third_party/crubit/rs_bindings_from_cc:generate_bindings_and_metadata
//third_party/crubit/rs_bindings_from_cc:src_code_gen
//third_party/crubit/rs_bindings_from_cc/generate_bindings:cc_api
//third_party/crubit/rs_bindings_from_cc/generate_bindings:generate_bindings
//third_party/crubit/rs_bindings_from_cc/generate_bindings:generate_function

PiperOrigin-RevId: 866633523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant