Allow template specializations to interleave generated definitions.#413
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 6, 2026
Merged
Allow template specializations to interleave generated definitions.#413copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_866094190
branch
7 times, most recently
from
72517c2 to
4600ea8
Compare
This requires wrapping each generated definition in it's own full namespace, rather than include everything in one top level namespace as we did before. This is so template specializations can appear between generated definitions while still being in the global namespace. Template specializations can depend and be depended upong by code we generate for items. This means they should get toposorted like main_apis are today. But template specializations need to reside in the global namespace. PiperOrigin-RevId: 866588552
copybara-service
bot
force-pushed
the
test_866094190
branch
from
4600ea8 to
c10678b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow template specializations to interleave generated definitions.
This requires wrapping each generated definition in it's own full
namespace, rather than include everything in one top level namespace as
we did before. This is so template specializations can appear between
generated definitions while still being in the global namespace.
Template specializations can depend and be depended upong by code we
generate for items. This means they should get toposorted like main_apis
are today. But template specializations need to reside in the global
namespace.