Add golden test for Co<T> type where T must be explicitly completed#383
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Add golden test for Co<T> type where T must be explicitly completed#383copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
In the Clang AST, `Co<T>` will never try to complete the instantiation of `T` because it doesn't actually need the completed type. This means that if `T` is not completed elsewhere, Crubit will also think it's incomplete and raise an error because it needs `T` to be complete. This change doesn't fix the issue, but demonstrates it happening. A followup change will ensure that Crubit manually attempts to complete the `T` type when it's reading from the clang AST, ensuring that Crubit won't complain about an incomplete `T` type that should obviously be completable, like `StatusOr<int>`. PiperOrigin-RevId: 864468461
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add golden test for Co type where T must be explicitly completed
In the Clang AST,
Co<T>will never try to complete the instantiation ofTbecause it doesn't actually need the completed type. This means that ifTis not completed elsewhere, Crubit will also think it's incomplete and raise an error because it needsTto be complete.This change doesn't fix the issue, but demonstrates it happening. A followup change will ensure that Crubit manually attempts to complete the
Ttype when it's reading from the clang AST, ensuring that Crubit won't complain about an incompleteTtype that should obviously be completable, likeStatusOr<int>.