-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: start.sh logs are being sent to stderr instead of stdout #4212 #4318
Conversation
/gcbrun |
@vitorguidi fixed the issue here, also worth noting the following: docker/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh
docker/chromium/base/start.sh
29:source /data/setup_clusterfuzz.sh
32:bash -ex /data/start_clusterfuzz.sh
docker/chromium/builder/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh
docker/chromium/tests-syncer/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh
docker/fuchsia/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh
docker/oss-fuzz/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh I did not realize and changed |
a714059
to
f4df493
Compare
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
1 similar comment
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
/gcbrun |
Note gcbrun will not test this code. @vitorguidi or @vitaliset could you please review this? |
All entries have been fixed @vitorguidi : ❯ rg "bash -ex "
docker/base/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1
docker/chromium/base/start.sh
32:bash -ex /data/start_clusterfuzz.sh 2>&1
docker/chromium/builder/start.sh
27:bash -ex /data/start_clusterfuzz.sh 2>&1
docker/chromium/tests-syncer/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1
docker/fuchsia/start.sh
27:bash -ex /data/start_clusterfuzz.sh 2>&1
docker/oss-fuzz/base/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach seems good, and this is easy to revert worst case. merging
Thanks for the contribution! |
/gcbrun |
Small change to the
docker/chromium/builder/start.sh
file. The change ensures that the output of the script is redirected to standard output instead of standard error due to the-x
flag.-x
I added2>&1
Fixing the issue.