Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start.sh logs are being sent to stderr instead of stdout #4212 #4318

Merged
merged 7 commits into from
Mar 18, 2025

Conversation

zvdy
Copy link
Contributor

@zvdy zvdy commented Oct 11, 2024

Small change to the docker/chromium/builder/start.sh file. The change ensures that the output of the script is redirected to standard output instead of standard error due to the -x flag.

  • In order to preserve the values from -x I added 2>&1 Fixing the issue.

@vitorguidi
Copy link
Collaborator

/gcbrun

@zvdy
Copy link
Contributor Author

zvdy commented Oct 15, 2024

@vitorguidi fixed the issue here, also worth noting the following:

docker/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh

docker/chromium/base/start.sh
29:source /data/setup_clusterfuzz.sh
32:bash -ex /data/start_clusterfuzz.sh

docker/chromium/builder/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/chromium/tests-syncer/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/fuchsia/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/oss-fuzz/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh

I did not realize and changed chromium instead of docker/base (fixed in e1be573)
Let me know if you want the rest of start.sh changed, or perhaps something

Copy link

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

1 similar comment
Copy link

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale label Mar 17, 2025
@zvdy
Copy link
Contributor Author

zvdy commented Mar 18, 2025

@github-actions github-actions bot removed the stale label Mar 18, 2025
@jonathanmetzman
Copy link
Collaborator

/gcbrun

@jonathanmetzman
Copy link
Collaborator

Note gcbrun will not test this code.

@vitorguidi or @vitaliset could you please review this?

@zvdy
Copy link
Contributor Author

zvdy commented Mar 18, 2025

All entries have been fixed @vitorguidi :

❯ rg "bash -ex "
docker/base/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/chromium/base/start.sh
32:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/chromium/builder/start.sh
27:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/chromium/tests-syncer/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/fuchsia/start.sh
27:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/oss-fuzz/base/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1

Copy link
Collaborator

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach seems good, and this is easy to revert worst case. merging

@vitorguidi
Copy link
Collaborator

Small change to the docker/chromium/builder/start.sh file. The change ensures that the output of the script is redirected to standard output instead of standard error due to the -x flag.

  • In order to preserve the values from -x I added 2>&1 Fixing the issue.

Thanks for the contribution!

@vitorguidi
Copy link
Collaborator

/gcbrun

@vitorguidi vitorguidi merged commit 1ca6b66 into google:master Mar 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants