feat: expose setup_complete event for ADK live#4475
Open
lottielin wants to merge 1 commit intogoogle:mainfrom
Open
feat: expose setup_complete event for ADK live#4475lottielin wants to merge 1 commit intogoogle:mainfrom
lottielin wants to merge 1 commit intogoogle:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
Hi @lottielin , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
Collaborator
|
Hi @wyf7107 , can you please review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2103 by exposing the
BidiGenerateContentSetupCompletesignal from Gemini Live API.Currently, clients using
run_livehave no definitive way to know when the initial model setup is finished and the WebSocket is ready to receive user input.This change:
gemini_llm_connection.pyto detect thesetup_complete(see API)setup_completeboolean field to theLlmResponsemodel_postprocess_liveinbase_llm_flow.pyto allowsetup_completeresponses to pass through the event filterTesting Plan
Unit Tests:
test_receive_setup_complete: verifysetup_completemessages are correctly adapted toLlmResponsetest_live_streaming_setup_completeintest_streaming.py: verifyrun_liveyields an event withsetup_complete