Skip to content

feat: add Databricks dialect awareness to DatabaseSessionService #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmolg1997 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

feat: add Databricks dialect awareness to DatabaseSessionService #4440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/google/adk/sessions/database_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
_MARIADB_DIALECT = "mariadb"
_MYSQL_DIALECT = "mysql"
_POSTGRESQL_DIALECT = "postgresql"
_DATABRICKS_DIALECT = "databricks"
# Tuple key order for in-process per-session lock maps:
# (app_name, user_id, session_id).
_SessionLockKey: TypeAlias = tuple[str, str, str]
Expand Down
6 changes: 6 additions & 0 deletions src/google/adk/sessions/schemas/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ def load_dialect_impl(self, dialect: Dialect):
if dialect.name == "mysql":
# Use LONGTEXT for MySQL to address the data too long issue
return dialect.type_descriptor(mysql.LONGTEXT)
if dialect.name == "databricks":
# Databricks SQL stores JSON as STRING; use Text (the default)
return dialect.type_descriptor(Text)
Comment on lines +40 to +42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This explicit check for the 'databricks' dialect is redundant. The default case on line 43 already returns dialect.type_descriptor(Text), which correctly handles the Databricks case (as noted in your comment). This if block can be removed to simplify the code without changing its behavior.

return dialect.type_descriptor(Text) # Default to Text for other dialects

def process_bind_param(self, value, dialect: Dialect):
Expand Down Expand Up @@ -64,4 +67,7 @@ class PreciseTimestamp(TypeDecorator):
def load_dialect_impl(self, dialect):
if dialect.name == "mysql":
return dialect.type_descriptor(mysql.DATETIME(fsp=6))
if dialect.name == "databricks":
# Databricks TIMESTAMP type natively supports microsecond precision
return dialect.type_descriptor(DateTime)
Comment on lines +70 to +72
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the DynamicJSON change, this explicit check for 'databricks' is redundant. The default implementation for this TypeDecorator is DateTime (via self.impl), and the fallback return self.impl on line 73 achieves the same result. This if block can be removed to make the code cleaner.

return self.impl
Loading